Feat: Argent one button connector logic #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 29, 2024 11:27
Cussone
changed the base branch from
develop
to
feat/argent-one-button-connector
bluecco
reviewed
Oct 31, 2024
bluecco
reviewed
Oct 31, 2024
bluecco
reviewed
Oct 31, 2024
bluecco
reviewed
Oct 31, 2024
| public showApprovalModal(_: RequestArguments): void { | ||
| if (device === "desktop") { | ||
| this.showModal({ | ||
| this.showModalOld({ |
Contributor
There was a problem hiding this comment.
why keeping the showModalOld?
saw a comment below, still needed or will just be removed in a followup pr?
bluecco
reviewed
Oct 31, 2024
bluecco
reviewed
Oct 31, 2024
…tor-logic Feat: Argent one button connector logic
# [2.4.0-beta.1](v2.3.2...v2.4.0-beta.1) (2024-10-31) ### Bug Fixes * adapt type external ([61ef1f0](61ef1f0)) * add missing tailwind's color tokens from `x-ui` ([1202fa3](1202fa3)) * color ([9039438](9039438)) * pass props and type `downloadLinks` ([6ff294e](6ff294e)) * ts error ([a76c303](a76c303)) * using wrong connector name/icon ([e991747](e991747)) ### Features * adapt modal to new features ([53d303e](53d303e)) * add component for rendering icons ([c57a8d8](c57a8d8)) * add new 1 button connector WIP ([6560d74](6560d74)) * add new prop to `ConnectOptions` ([966a9e7](966a9e7)) * add new UI elements ([1b4066b](1b4066b)) * create helpers for connectors ([ea4008b](ea4008b)) * create modal helpers ([015dff2](015dff2)) * handle new UI and only QR code approach ([c743c6d](c743c6d)) * improve type StarknetkitCompoundConnector ([3fd36a7](3fd36a7)) * programmatically show install extension section ([d571de8](d571de8))
# [2.4.0-beta.2](v2.4.0-beta.1...v2.4.0-beta.2) (2024-10-31) ### Features * export `StarknetkitCompoundConnector` ([0e4aa84](0e4aa84))
# [2.4.0-beta.3](v2.4.0-beta.2...v2.4.0-beta.3) (2024-11-01) ### Bug Fixes * case when `window` is `undefined` in `getInjectedArgentX` ([de4cae8](de4cae8))
# [2.4.0-beta.4](v2.4.0-beta.3...v2.4.0-beta.4) (2024-11-01) ### Bug Fixes * ignore ts error ([96c06e1](96c06e1)) * logical error with modal closing ([ff8305d](ff8305d)) * logical error, destroy modal if `resultType !== "wallet"` ([3c71667](3c71667)) * passing wrong theme to `DynamicIcon` ([5e7cef2](5e7cef2))
…tor-qa-fixes Fix: Fixes after QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Adding changes to logic to support 1 button connector
Checklist