Skip to content

Conversation

@bluecco
Copy link
Contributor

@bluecco bluecco commented Feb 13, 2025

Issue / feature description

Quick description of the issue or the feature that is implemented in the pr ie: add new transitions between screens

Changes

quick list regarding the related changes within the pr

ie:

  • add new connector
  • fix injected connector
  • ...

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@bluecco bluecco requested a review from Cussone February 13, 2025 08:59
@bluecco
Copy link
Contributor Author

bluecco commented Feb 13, 2025

image

@bluecco
Copy link
Contributor Author

bluecco commented Feb 13, 2025

@Cussone we will need to have a proper upgrade to vite v6

@Cussone
Copy link
Member

Cussone commented Feb 13, 2025

@Cussone we will need to have a proper upgrade to vite v6

Yup, I'm aware of that. That's why I already downgraded to v4 on 1 button connector here 4097ea4

Let's do that once 1 button connector goes live!

@bluecco bluecco merged commit b5c65c4 into develop Feb 13, 2025
1 check passed
@bluecco bluecco deleted the fix/rollback-vite branch February 13, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants