Add Cartridge Controller connector #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why so draft? 😆 |
kronosapiens
commented
Jun 12, 2025
bluecco
approved these changes
Jul 8, 2025
Contributor
Author
|
Thanks @bluecco. It says that the workflow also needs approval? |
Contributor
|
hey @kronosapiens, should start automatically |
Contributor
Author
|
Hi @bluecco, I rebased the PR onto develop. Can you re-approve the workflow? Something in the build failed, but it didn't seem related to my PR. |
Contributor
Author
Cussone
approved these changes
Jul 14, 2025
Member
@kronosapiens fixed the issue |
Contributor
Author
|
@Cussone thank you! |
|
@kronosapiens I tried to use the new connector, but for some reason it didn't connect, probably I didn't configure it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Add a connector for the Cartridge Controller
Changes
Add a new directory under
src/controllersdefining astarknetkit-compatible connector for ControllerChecklist
Limitations
Currently the Controller has support for transactions and message-signing (the primary gaming use-cases). Additional wallet functionality can be added in response to user requests.
The Controller supports only revision 1 domain separators when signing messages. Dapps will need to upgrade to use revision 1 in order to use Controller. See SNIP-12 for more information about domain separators.