feat: Add comprehensive Sendable conformance and thread safety [IOS-3436] #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dioKaratzas
changed the title
dioKaratzas
force-pushed
the
tech/sendable
branch
6 times, most recently
from
5cbf6e5 to
e6fa0e6
Compare
dioKaratzas
force-pushed
the
tech/sendable
branch
from
e6fa0e6 to
995cdee
Compare
- https://argent.atlassian.net/browse/IOS-3436 Summary: - Add ThreadSafeBox utility class for thread-safe property wrapper - Implement Sendable conformance across all major classes and protocols: - Client classes (EthereumHttpClient, EthereumWebSocketClient, etc.) - ENS classes (ENSResolver, ENSMultiResolver, EthereumNameService) - ERC standard implementations (ERC20, ERC721, ERC1271, ERC165) - Account management (EthereumAccount, EthereumKeyLocalStorage) - Contract and ABI types - Network providers and utilities - Convert ENSResolver to use thread-safe property access with ThreadSafeBox - Fix ENSMultiResolver thread safety with atomic operations for queries and responses - Update EthereumKeyLocalStorage with thread-safe address handling - Mark classes as final where appropriate for performance - Use @unchecked Sendable for classes with internal synchronization - Update test classes to conform to Sendable requirements - Ensure all protocols inherit Sendable conformance where needed This enables safe concurrent usage across the entire web3.swift library while maintaining backward compatibility and performance.
dioKaratzas
force-pushed
the
tech/sendable
branch
from
34bc125 to
d0b84ab
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Sendable conformance and thread safety to the web3.swift library to enable safe concurrent usage across Swift 6 strict concurrency checks. It introduces a new ThreadSafeBox utility for thread-safe property access and updates all major classes, protocols, and structures with appropriate Sendable conformance.
- Add ThreadSafeBox utility class for thread-safe property wrapper
- Implement Sendable conformance across client classes, ERC standards, ENS services, account management, and contract types
- Update completion handlers and closures with @sendable annotations for concurrent safety
Reviewed Changes
Copilot reviewed 55 out of 56 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web3swift/src/Utils/ThreadSafeBox.swift | New thread-safe wrapper utility using NSLock for atomic property access |
| web3swift/src/ENS/ENSResolver.swift | Convert to use ThreadSafeBox for thread-safe wildcard support tracking |
| web3swift/src/ENS/ENSMultiResolver.swift | Add thread safety with atomic operations for queries and responses |
| web3swift/src/Account/EthereumKeyLocalStorage.swift | Update address handling with ThreadSafeBox for thread safety |
| web3swift/src/ERC20/ERC20.swift | Add @unchecked Sendable conformance and @sendable completion handlers |
| web3swift/src/ERC721/ERC721.swift | Add @unchecked Sendable conformance and @sendable completion handlers |
| web3swift/src/Client/HTTP/EthereumHttpClient.swift | Add @unchecked Sendable conformance to HTTP client |
| web3swift/src/Client/WSS/EthereumWebSocketClient.swift | Add @unchecked Sendable conformance and @sendable closures |
| web3swift/src/Utils/KeyUtil.swift | Replace deprecated assign with update method |
| web3swift/src/Contract/Statically Typed/EthereumClient+Static.swift | Add debug print statement and EventFilter Sendable conformance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| return try parseOrFail(data) | ||
| } catch { | ||
| print("Error calling function: \(error)") |
There was a problem hiding this comment.
This debug print statement should be removed from production code or replaced with proper logging using the existing logger infrastructure.
| var size = 65 | ||
| var rv = Data(count: size) | ||
| rv.withUnsafeMutableBytes { | ||
| _ = rv.withUnsafeMutableBytes { |
There was a problem hiding this comment.
Discarding the return value with '_' is unnecessary here. The withUnsafeMutableBytes method returns Void in this context, so the assignment can be removed.
Suggested change
| _ = rv.withUnsafeMutableBytes { | |
| rv.withUnsafeMutableBytes { |
DarthMike
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://argent.atlassian.net/browse/IOS-3436
This enables safe concurrent usage across the entire web3.swift library
while maintaining backward compatibility and performance.