Skip to content

Conversation

@My-laniaKeA
Copy link

Issue
Attempting to log after executing pipeline.run() may result in an error. This issue arises due to setup_logging(), which modifies the root logger using getLogger(), potentially causing unintended side effects.

Proposed fix
Modify setup_logging() to ensure it configures a dedicated logger for the pipeline.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #1127 will degrade performances by 92.56%

Comparing My-laniaKeA:fix-root-logger (cc474da) with develop (7dc5f70)

Summary

❌ 1 regression

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cache_time 714.7 ms 9,602.5 ms -92.56%

log_level = "INFO"

root_logger = logging.getLogger()
root_logger = logging.getLogger("distilabel.root")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@My-laniaKeA - should this not be "distilabel" to have the parent level and not a sibling?

@dameikle dameikle changed the base branch from main to develop November 5, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants