Experimental: use Tokenizers without templates - #298
Draft
pcuenca wants to merge 1 commit into
Draft
Conversation
Not to be merged, for testing purposes only.
pcuenca
marked this pull request as draft
January 30, 2025 11:36
Collaborator
Author
|
Would be curious to hear your thoughts @ZachNagengast, and ideas on how to move forward. |
Contributor
|
This looks good to me, the build error is a dep from TensorUtils. Do you think it makes sense to split up the Generation target too? Otherwise, we can just adjust the function that uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to be merged, for testing purposes only.
Reference: huggingface/swift-transformers#168, huggingface/swift-transformers#166 (in particular: huggingface/swift-transformers#166 (review))