fix: replace force-unwraps in TextDecoder with safe error handling#420
Open
claudeaceae wants to merge 1 commit intoargmaxinc:mainfrom
Open
fix: replace force-unwraps in TextDecoder with safe error handling#420claudeaceae wants to merge 1 commit intoargmaxinc:mainfrom
claudeaceae wants to merge 1 commit intoargmaxinc:mainfrom
Conversation
Replace 6 force-unwrap operations in TextDecoder.swift that can crash during sustained rapid transcription (e.g., live preview at ~200ms intervals). The decoder state can degrade over many sequential calls, causing optional values to be nil where force-unwraps assume non-nil. Changes: - decoderOutput.logits! → guard let with WhisperError.decodingLogitsFailed - initialPrompt.last! → guard let with WhisperError.prepareDecoderInputsFailed - sampleResult.tokens.last! → guard let with WhisperError.decodingFailed - sampleResult.logProbs.last! → guard let with WhisperError.decodingFailed Callers can now catch and handle these errors gracefully instead of crashing the entire app. Fixes argmaxinc#414 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextDecoder.swiftthat crash during sustained rapid transcriptiondecoderOutput.logits!→guard letwithWhisperError.decodingLogitsFailed(2 sites:detectLanguageanddecodeText)decoderInputs.initialPrompt.last!→guard letwithWhisperError.prepareDecoderInputsFailedsampleResult.tokens.last!→guard letwithWhisperError.decodingFailed(2 sites)sampleResult.logProbs.last!→guard letwithWhisperError.decodingFailedAll replacements use existing
WhisperErrorcases so callers can catch and handle errors gracefully instead of crashing the app.Test plan
Fixes #414
🤖 Generated with Claude Code