Skip to content

WhisperKit : propagate useBackgroundDownloadSession into config fetch (#337) #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achyutbenz19 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WhisperKit : propagate useBackgroundDownloadSession into config fetch (#337) #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions Sources/WhisperKit/Core/WhisperKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,19 @@ open class WhisperKit {
downloadBase: URL? = nil,
token: String? = nil,
remoteConfigName: String = Constants.defaultRemoteConfigName,
endpoint: String = Constants.defaultRemoteEndpoint
endpoint: String = Constants.defaultRemoteEndpoint,
useBackgroundSession: Bool = false
) async -> ModelSupport {
let deviceName = Self.deviceName()
let config = await Self.fetchModelSupportConfig(
from: repo,
downloadBase: downloadBase,
token: token,
remoteConfigName: remoteConfigName,
endpoint: endpoint
endpoint: endpoint,
useBackgroundSession: useBackgroundSession
)

return ModelUtilities.modelSupport(for: deviceName, from: config)
}

Expand All @@ -183,9 +185,10 @@ open class WhisperKit {
downloadBase: URL? = nil,
token: String? = nil,
remoteConfigName: String = Constants.defaultRemoteConfigName,
endpoint: String = Constants.defaultRemoteEndpoint
endpoint: String = Constants.defaultRemoteEndpoint,
useBackgroundSession: Bool = false
) async -> ModelSupportConfig {
let hubApi = HubApiWrapper(downloadBase: downloadBase, hfToken: token, endpoint: endpoint)
let hubApi = HubApiWrapper(downloadBase: downloadBase, hfToken: token, endpoint: endpoint, useBackgroundSession: useBackgroundSession)
let repoRef = HubApiWrapper.Repo(id: repo)
var modelSupportConfig = Constants.fallbackModelSupportConfig

Expand Down Expand Up @@ -322,12 +325,16 @@ open class WhisperKit {
modelVariant = model
} else {
// Model not specified, fetch remote config to get the recommended default
// Propagate useBackgroundDownloadSession so the pre-download config fetch
// also runs through the background URLSession when the caller opted in.
// ref: https://github.com/argmaxinc/argmax-oss-swift/issues/337
let modelSupport = await WhisperKit.recommendedRemoteModels(
from: repo,
downloadBase: downloadBase,
token: modelToken,
remoteConfigName: remoteConfigName,
endpoint: endpoint
endpoint: endpoint,
useBackgroundSession: useBackgroundDownloadSession
)
modelVariant = modelSupport.default
}
Expand Down