propagate rand 0.9 xoshiro 0.7 deps #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-k
reviewed
Mar 22, 2025
stefan-k
reviewed
Mar 22, 2025
| @@ -55,4 +55,4 @@ maintenance = { status = "actively-developed" } | |||
|
|
|||
| [package.metadata.docs.rs] | |||
| targets = ["x86_64-unknown-linux-gnu"] | |||
| features = ["serde1"] | |||
stefan-k
reviewed
Mar 22, 2025
| @@ -146,7 +146,7 @@ impl<P, F, R> ParticleSwarm<P, F, R> | |||
| where | |||
| P: Clone + SyncAlias + ArgminSub<P, P> + ArgminMul<F, P> + ArgminRandom + ArgminZeroLike, | |||
| F: ArgminFloat, | |||
| R: Rng, | |||
| R: Rng + RngCore, | |||
There was a problem hiding this comment.
Could you explain why this is necessary, please?
stefan-k
reviewed
Mar 22, 2025
| @@ -511,7 +511,7 @@ where | |||
| // `1 / (1 + exp((next_cost - prev_cost) / current_temperature))`, | |||
| // | |||
| // which will always be between 0 and 0.5. | |||
| let prob: f64 = self.rng.gen(); | |||
| let prob: f64 = self.rng.random(); | |||
There was a problem hiding this comment.
Could you point me to the documentation where this change is described, please?
|
Thanks for the contribution! I have a few minor questions. |
|
first i got rid of the feature, then i saw it was changed to serde , forgot
to re-establish it
Le sam. 22 mars 2025 à 15:07, Stefan Kroboth ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In crates/argmin/Cargo.toml
<#580 (comment)>:
> @@ -43,7 +43,7 @@ argmin-checkpointing-file = { path = "../argmin-checkpointing-file" }
[features]
default = []
wasm-bindgen = ["getrandom/js"]
-serde1 = ["serde", "rand_xoshiro/serde1"]
Why is this feature removed instead of changed to rand_xoshiro/serde as
mentioned in the changelog
<https://github.com/rust-random/rngs/blob/master/rand_xoshiro/CHANGELOG.md>
?
—
Reply to this email directly, view it on GitHub
<#580 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXM7NJ4VWVGOOEQAVKVOMD2VVVBLAVCNFSM6AAAAABZQFQ5IWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBYGA2DGMRTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
fn gen <https://docs.rs/rand/latest/rand/trait.Rng.html#method.gen><T>(&mut
self) -> T
where StandardUniform
<https://docs.rs/rand/latest/rand/distr/struct.StandardUniform.html>:
Distribution
<https://docs.rs/rand/latest/rand/distr/trait.Distribution.html><T>,
👎Deprecated since 0.9.0: Renamed to random to avoid conflict with the new
gen keyword in Rust 2024.
Alias for Rng::random
<https://docs.rs/rand/latest/rand/trait.Rng.html#method.random>.
Le sam. 22 mars 2025 à 15:12, Stefan Kroboth ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In crates/argmin/src/solver/simulatedannealing/mod.rs
<#580 (comment)>:
> @@ -511,7 +511,7 @@ where
// `1 / (1 + exp((next_cost - prev_cost) / current_temperature))`,
//
// which will always be between 0 and 0.5.
- let prob: f64 = self.rng.gen();
+ let prob: f64 = self.rng.random();
Could you point me to the documentation where this change is described,
please?
—
Reply to this email directly, view it on GitHub
<#580 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXM7NIYLUF3GXNY3WXVSTL2VVVT5AVCNFSM6AAAAABZQFQ5IWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBYGA2DKOBZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
coompiler asked it during modifs but in fact uncessary. Rng : RngCore
Le sam. 22 mars 2025 à 15:11, Stefan Kroboth ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In crates/argmin/src/solver/particleswarm/mod.rs
<#580 (comment)>:
> @@ -146,7 +146,7 @@ impl<P, F, R> ParticleSwarm<P, F, R>
where
P: Clone + SyncAlias + ArgminSub<P, P> + ArgminMul<F, P> + ArgminRandom + ArgminZeroLike,
F: ArgminFloat,
- R: Rng,
+ R: Rng + RngCore,
Could you explain why this is necessary, please?
—
Reply to this email directly, view it on GitHub
<#580 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXM7NIKGAWASYFK6NAI2O32VVVQJAVCNFSM6AAAAABZQFQ5IWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMBYGA2DKNRSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 92.13% 92.12% -0.01%
==========================================
Files 177 177
Lines 23672 23672
==========================================
- Hits 21810 21808 -2
- Misses 1862 1864 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Last pb is wasm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates deps.
from_entropy replaces by from_os_rng (rand docs recommans chacha for portability...)
The rest should be ok. all tests passed.