Skip to content

Render math in argmin-testfunctions with KaTeX (part 2) #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

airwoodix
Copy link
Contributor

Follow-up to #530.

Render the math in argmin-testfunctions with KaTeX for the documentation that had not been converted yet. No code changes.

The function in mccorminck.rs seems to be call "McCormick" (without the n) on the Internet. See e.g. wikipedia and here. I used this spelling in the documentation, but didn't change the function or module name, to not introduce a breaking change in this documentation-only PR. @stefan-k Would you consider a PR changing the function and module names?

@airwoodix airwoodix marked this pull request as ready for review March 21, 2025 19:32
Copy link
Member

@stefan-k stefan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, this is again absolutely excellent! :)

Oops, at least I was consistent with the typo! I'd appreciate it if you could fix this in a PR, even if it is a breaking change :)

@stefan-k
Copy link
Member

Pipeline should be fixed with #582

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (b35808a) to head (831fc49).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   92.13%   92.12%   -0.01%     
==========================================
  Files         177      177              
  Lines       23672    23672              
==========================================
- Hits        21810    21808       -2     
- Misses       1862     1864       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@airwoodix
Copy link
Contributor Author

Thanks @stefan-k for the feedback and the pipeline fix. I rebased this PR's branch onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants