Support wasm32-unknown-unknown without wasm-bindgen
#583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 92.13% 92.12% -0.01%
==========================================
Files 177 177
Lines 23672 23672
==========================================
- Hits 21810 21808 -2
- Misses 1862 1864 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stefan-k My apologies for the failing CI jobs in 68cf721 and dc43934. I now tested this PR in my own fork (rikhuijzer#1) and CI should pass now. I also added a test that explicitly tests this My compliments by the way for the CI testing setup. The tests are very thorough. |
rikhuijzer
changed the title
wasm32-unknown-unknown compilationwasm32-unknown-unknown without wasm-bindgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making this software available. I think numerical packages in pure Rust are really important.
This PR allows for succesfully building armin with
As a bit of background, the wasm (synonym: WebAssembly) situation is a bit complication right now. As I understand it, most wasm targets assume that Javascript is available too. So that's why
getrandom/jsoften works. However, more and more wasm targets are moving away from Javascript. Wasmtime, for example, is a wasm runtime that does not support Javascript. This is useful for example for plugin systems like is used by Typst or Zellij. Both allow developers to write plugins which then can be used by users. But to not compromise the whole system, the plugins are sandboxed by default. So these plugins typically are not allowed to access the filesystem, or other system interfaces; also not via JS bindgen.But I think it would be very nice if we could argmin in these barebone environments. To do so, this PR suggests to fix the build.