Skip to content

test(e2e): run e2e tests with destination based mapping#1028

Draft
chetan-rns wants to merge 3 commits into
argoproj-labs:mainfrom
chetan-rns:improve-dst-e2e
Draft

test(e2e): run e2e tests with destination based mapping#1028
chetan-rns wants to merge 3 commits into
argoproj-labs:mainfrom
chetan-rns:improve-dst-e2e

Conversation

@chetan-rns

Copy link
Copy Markdown
Collaborator

What does this PR do / why we need it:

Currently, the e2e tests cover scenarios for namespace-based mapping and have minimal coverage for destination-based mapping. This can lead to issues where a feature may not work properly in one of the mappings. We need to ensure the quality of the argocd-agent in both the mapping modes. In this PR, we update the existing e2e tests to run in both modes. Using environment variables, we can run the same e2e tests with different configurations in the GitHub actions.

Assisted-by: Cursor

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

Assisted-by: Cursor
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d47c641c-76b5-453e-a918-530d9e937123

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@codecov-commenter

codecov-commenter commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.07%. Comparing base (8cf8718) to head (5709591).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   48.06%   48.07%   +0.01%     
==========================================
  Files         125      125              
  Lines       18789    18789              
==========================================
+ Hits         9030     9032       +2     
+ Misses       8943     8941       -2     
  Partials      816      816              
Flag Coverage Δ
unit-tests 48.07% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants