test(e2e): run e2e tests with destination based mapping#1028
test(e2e): run e2e tests with destination based mapping#1028chetan-rns wants to merge 3 commits into
Conversation
Assisted-by: Cursor Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 48.06% 48.07% +0.01%
==========================================
Files 125 125
Lines 18789 18789
==========================================
+ Hits 9030 9032 +2
+ Misses 8943 8941 -2
Partials 816 816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
What does this PR do / why we need it:
Currently, the e2e tests cover scenarios for namespace-based mapping and have minimal coverage for destination-based mapping. This can lead to issues where a feature may not work properly in one of the mappings. We need to ensure the quality of the argocd-agent in both the mapping modes. In this PR, we update the existing e2e tests to run in both modes. Using environment variables, we can run the same e2e tests with different configurations in the GitHub actions.
Assisted-by: Cursor
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
Checklist