Skip to content

feat(Makefile): Relabel the volume for selinux compatibility#2207

Merged
svghadi merged 1 commit into
argoproj-labs:masterfrom
olivergondza:fix-make-serve-docs-selinux
May 25, 2026
Merged

feat(Makefile): Relabel the volume for selinux compatibility#2207
svghadi merged 1 commit into
argoproj-labs:masterfrom
olivergondza:fix-make-serve-docs-selinux

Conversation

@olivergondza

@olivergondza olivergondza commented May 21, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

How to test changes / Special notes to the reviewer:

Run make serve-docs on a selinux-enabled host.

Summary by CodeRabbit

  • Chores
    • Updated documentation server configuration to improve compatibility with SELinux-enabled systems.

Review Change Stack

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a4c5796-c334-4526-a4a5-c6a3fd587e41

📥 Commits

Reviewing files that changed from the base of the PR and between 41114a7 and 249a222.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The serve-docs Makefile target's Docker volume mount is updated to include the :Z SELinux relabeling option, changing from -v $(PWD):/argocd-operator to -v $(PWD):/argocd-operator:Z. This allows the container to properly access the mounted host directory with SELinux policies enforced.

Changes

Documentation Server Configuration

Layer / File(s) Summary
SELinux-enabled docs server volume mount
Makefile
The serve-docs target now mounts the project directory with SELinux relabeling enabled by adding the :Z option to the volume bind argument.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jgwest
  • svghadi

Poem

🐰 A tiny flag, so small yet true,
:Z for SELinux shines through,
Docs now serve with proper grace,
Context labels in their place!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding SELinux relabel option to the volume mount in the Makefile's serve-docs target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@svghadi svghadi merged commit d5c54c7 into argoproj-labs:master May 25, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants