feat: sync feature set pygithub#60
Merged
coreycaverly merged 22 commits intoFeb 27, 2026
Merged
Conversation
fix: drop support for outdated python
kaosx5s
requested review from
AgarFu,
coreycaverly and
jnevelson
as code owners
Signed-off-by: Corey Caverly <corey.caverly@autodesk.com>
* Allow path define on get files (argoproj-labs#42) * Add support for setting a path on get_files Signed-off-by: kaosx5s <jeremy.xfives@gmail.com> * fix repo test after target change in 3.6.0 Signed-off-by: kaosx5s <> --------- Signed-off-by: kaosx5s <jeremy.xfives@gmail.com> Signed-off-by: kaosx5s <> Co-authored-by: kaosx5s <> Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Removed transient line (argoproj-labs#50) Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Revving version for release (argoproj-labs#51) Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> Co-authored-by: Corey Caverly <corey.caverly@autodesk.com> Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Update docker-publish.yml (argoproj-labs#52) * Update docker-publish.yml Removing Dockerhub and just doing ghcr Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Revving for release Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Decided to remove and not just comment out Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> --------- Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * retry on timeout (argoproj-labs#54) * retry on timeout Signed-off-by: zliu3 <zejun_liu@intuit.com> * add unit test and throw exception on timeout Signed-off-by: zliu3 <zejun_liu@intuit.com> * update README.md Signed-off-by: zliu3 <zejun_liu@intuit.com> * add test to make sure retry on exception, add a good case Signed-off-by: zliu3 <zejun_liu@intuit.com> --------- Signed-off-by: zliu3 <zejun_liu@intuit.com> Co-authored-by: zliu3 <zejun_liu@intuit.com> Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * feat: drop support for older python versions, support up to 2.6.1 for pygithub (argoproj-labs#56) * fix: drop support for outdated python * fix: update pygithub to support 2.2.0 or higher * fix: update tests for newer pytest * fix: check pygithub 2.4.0 support * fix: check pygithub 2.6.1 support * fix: set lazy to be false by default for backwards compatibility * fix: remove completed param for pygithub 2.6.0 support * fix: add required requester for pygithub 2.6.0 support * fix: fix param typo * fix: make requester a magicmock * fix: update tests for new lazy param * fix: update lazy from str to bool Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * revving for release Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Revving python version for publish Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Updating readme to reflect new location of docker images Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> * Revving for new release Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> --------- Signed-off-by: kaosx5s <jeremy.xfives@gmail.com> Signed-off-by: kaosx5s <> Signed-off-by: Corey Caverly <corey.caverly@autodesk.com> Signed-off-by: zliu3 <zejun_liu@intuit.com> Co-authored-by: Jeremy <1028480+kaosx5s@users.noreply.github.com> Co-authored-by: zejunintuit <zejunliuajk@gmail.com> Co-authored-by: zliu3 <zejun_liu@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where creating pull requests would fail due to drift between Gordian and PyGithub's function signatures
Adds support for draft PR creation
Adds support for setting the
pool_sizeof theGithubclient fromPyGithubFixes a bug where non
404responses fromPyGithub's REST caller would not bubble up properly (get_files() raises "TypeError: 'NoneType' object is not iterable" when _get_repo_contents encounters non-404 GithubException #59 )Relevant Issues :
get_files() raises "TypeError: 'NoneType' object is not iterable" when _get_repo_contents encounters non-404 GithubException #59
Type of change :
Other: