feat: add server-side filtering for list_applications #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
reviewed
Oct 8, 2025
|
|
||
| public async listApplications(params?: { search?: string }) { | ||
| const { body } = await this.client.get<V1alpha1ApplicationList>(`/api/v1/applications`, params); | ||
| public async listApplications(filters?: { |
There was a problem hiding this comment.
Looks like we still need to use filters parameter in request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list_applications tool showed unfiltered results even when a search term was provided, resulting in huge token consumption (especially in setups with very large amount of apps like mine). The underlying Argo CD API does not support filtering, so this PR adds server-side filtering after fetching the list.
The way it currently kind of works is that the LLM receives the full list of apps and then the LLM filters it out. This way is much more efficient and allows for filtering for more than just application name.
This was tested on my instance and works very well on filtering only the relevant information.
Feel free to give feedback and review :)