Skip to content

feat:(dex) allow dex storage to be configured #7089 #22559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IanMoroney
Copy link

@IanMoroney IanMoroney commented Apr 3, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #7089

This PR allows for different storage options to be presented to the Dex config, and if no storage option is given, reverts to the current in-memory storage.

@IanMoroney IanMoroney requested a review from a team as a code owner April 3, 2025 11:49
Copy link

bunnyshell bot commented Apr 3, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@IanMoroney
Copy link
Author

I'd be happy to include some documentation for this to indicate that this is now possible, i'll just need a steer on where I should put that documentation.

@IanMoroney IanMoroney changed the title allow dex storage to be configured feat:(dex) allow dex storage to be configured #7089 Apr 3, 2025
Ian Moroney and others added 2 commits April 3, 2025 12:19
Signed-off-by: Ian Moroney <[email protected]>
@IanMoroney IanMoroney force-pushed the feature/dex-storage branch from dd3bceb to 29a99d0 Compare April 3, 2025 12:19
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (38b4cba) to head (29a99d0).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
util/dex/config.go 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22559      +/-   ##
==========================================
- Coverage   56.06%   55.95%   -0.12%     
==========================================
  Files         343      343              
  Lines       57527    57544      +17     
==========================================
- Hits        32251    32197      -54     
- Misses      22635    22694      +59     
- Partials     2641     2653      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanMoroney
Copy link
Author

@crenshaw-dev , any feedback on this if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run dex server in HA
1 participant