Skip to content

fix: ArgoCD CLI diff shows installationID annotations (#22409) #22567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

muma378
Copy link
Contributor

@muma378 muma378 commented Apr 4, 2025

Closes #22409

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@muma378 muma378 requested a review from a team as a code owner April 4, 2025 04:59
Copy link

bunnyshell bot commented Apr 4, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@89d1ff9). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/settings/settings.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22567   +/-   ##
=========================================
  Coverage          ?   56.16%           
=========================================
  Files             ?      343           
  Lines             ?    57540           
  Branches          ?        0           
=========================================
  Hits              ?    32318           
  Misses            ?    22561           
  Partials          ?     2661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muma378 muma378 force-pushed the fix/diff-installation-id branch from 925fb40 to 96e3cc4 Compare April 4, 2025 09:46
@muma378
Copy link
Contributor Author

muma378 commented Apr 7, 2025

A little bit weird:

b475c084-cd73-4acc-8bc8-f161a00d4e00

no more displaying installation id but shows status diff, is it correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD CLI diff shows installationID annotations when there is a diff on all resources
1 participant