fix: add shellcheck and fix a few warnings

.github/workflows/ci-build.yaml

@@ -10,6 +10,7 @@ on:
     branches:
       - 'master'
       - 'release-*'
+  workflow_dispatch:
 
 env:
   # Golang version to use across CI steps
@@ -333,6 +334,15 @@ jobs:
         run: yarn lint
         working-directory: ui/
 
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
+      - run: |
+          sudo apt-get install shellcheck
+          shellcheck -e SC2086 -e SC2046 -e SC2068 -e SC2206 -e SC2048 -e SC2059 -e SC2154 -e SC2034 -e SC2016 -e SC2128 -e SC1091 -e SC2207  $(find . -type f -name '*.sh') | tee sc.log
+          test ! -s sc.log
+
   analyze:
     name: Process & analyze test artifacts
     if: ${{ needs.changes.outputs.backend == 'true' || needs.changes.outputs.frontend == 'true' }}

hack/generate-actions-list.sh

@@ -1 +1,3 @@
-find resource_customizations -name action.lua | sed 's/resource_customizations\/\(.*\)\/actions\/\(.*\)\/action.lua/- [\1\/\2](https:\/\/github.com\/argoproj\/argo-cd\/blob\/master\/resource_customizations\/\1\/actions\/\2\/action.lua)/' | sort | uniq > docs/operator-manual/resource_actions_builtin.md
+#!/usr/bin/env bash
+
+find resource_customizations -name action.lua | sed 's/resource_customizations\/\(.*\)\/actions\/\(.*\)\/action.lua/- [\1\/\2](https:\/\/github.com\/argoproj\/argo-cd\/blob\/master\/resource_customizations\/\1\/actions\/\2\/action.lua)/' | sort | uniq > docs/operator-manual/resource_actions_builtin.md

hack/trigger-release.sh

@@ -14,7 +14,7 @@ fi
 
 # Target (version) tag must match version scheme vMAJOR.MINOR.PATCH with an
 # optional pre-release tag.
-if ! echo "${NEW_TAG}" | egrep -q '^v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)*$'; then
+if ! echo "${NEW_TAG}" | grep -E -q '^v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)*$'; then
 	echo "!! Malformed version tag: '${NEW_TAG}', must match 'vMAJOR.MINOR.PATCH(-rcX)'" >&2
 	exit 1
 fi

test/e2e/testdata/cmp-preserve-file-mode/script.sh

@@ -1,8 +1,10 @@
+#!/usr/bin/env bash
+
 cat << EOF
 apiVersion: v1
 kind: ConfigMap
 metadata:
   name: test-cm
 data:
   foo: bar
-EOF
+EOF

ui/scripts/build_docker.sh

@@ -4,9 +4,9 @@ set -e
 
 TAG=${IMAGE_TAG:-'latest'}
 
-docker build --build-arg ARGO_VERSION=${TAG} -t ${IMAGE_NAMESPACE:-`whoami`}/argocd-ui:${TAG} .
+docker build --build-arg ARGO_VERSION=${TAG} -t ${IMAGE_NAMESPACE:-$(whoami)}/argocd-ui:${TAG} .
 
 if [ "$DOCKER_PUSH" == "true" ]
 then
-    docker push ${IMAGE_NAMESPACE:-`whoami`}/argocd-ui:${TAG}
+    docker push ${IMAGE_NAMESPACE:-$(whoami)}/argocd-ui:${TAG}
 fi

util/io/files/testdata/executable/script.sh

@@ -1 +1,3 @@
-echo hello world
+#!/usr/bin/env bash
+
+echo hello world