Skip to content

feat: Add support for Azure AD groups overflow#24900

Closed
dizco wants to merge 6 commits intoargoproj:masterfrom
dizco:user/gb/azure-ad-overflow
Closed

feat: Add support for Azure AD groups overflow#24900
dizco wants to merge 6 commits intoargoproj:masterfrom
dizco:user/gb/azure-ad-overflow

Conversation

@dizco
Copy link
Copy Markdown

@dizco dizco commented Oct 8, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Oct 8, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 64.19214% with 82 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@8273c3a). Learn more about missing BASE report.
⚠️ Report is 978 commits behind head on master.

Files with missing lines Patch % Lines
util/oidc/oidc.go 61.83% 37 Missing and 13 partials ⚠️
util/jwt/jwt.go 73.13% 12 Missing and 6 partials ⚠️
util/settings/settings.go 54.83% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #24900   +/-   ##
=========================================
  Coverage          ?   60.76%           
=========================================
  Files             ?      350           
  Lines             ?    60632           
  Branches          ?        0           
=========================================
  Hits              ?    36846           
  Misses            ?    20850           
  Partials          ?     2936

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dizco added 5 commits October 8, 2025 14:54
@dizco
refactor: Change implementation to Azure AD groups overflow specific
5f02749 
Instead of supporting generic distributed claims, this implementation now
specifically handles Azure AD groups overflow scenarios:

- Changed configuration from enableDistributedClaims to enableAzureGroupsOverflow
- Renamed timeout setting from distributedClaimsTimeout to azureGroupsOverflowTimeout
- Updated JWT utilities to specifically detect Azure AD groups overflow
- Modified OIDC client to only handle Azure AD Graph API calls
- Simplified implementation by removing generic distributed claims support
- Updated tests to reflect Azure AD specific functionality
- Renamed documentation to azure-ad-groups-overflow.md

This focused implementation addresses the specific issue where Azure AD
users with >200 groups need their group memberships fetched from the
Microsoft Graph API due to JWT size limitations.
@dizco
up
4e7530f
@dizco
code
f83cb0a
@dizco
up
f3bd90d
@dizco
update endpoint
138ebb1
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

This pull request has been marked as stale because it has had no activity for 90 days. Please comment if this is still relevant.

@github-actions github-actions Bot added Stale No activity for over 90 days and removed Stale No activity for over 90 days labels Feb 11, 2026
@dizco dizco closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dizco