Skip to content

Conversation

mmorel-35
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Oct 9, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mmorel-35 mmorel-35 changed the title refactor: remove ctx context from settings manager to enforce statelessness; context now passed only to methods chore: remove ctx context from settings manager to enforce statelessness; context now passed only to methods Oct 9, 2025
@mmorel-35 mmorel-35 force-pushed the settings-manager branch 4 times, most recently from ce66c95 to a19d9bc Compare October 9, 2025 07:53
@mmorel-35 mmorel-35 marked this pull request as ready for review October 9, 2025 08:08
@mmorel-35 mmorel-35 requested review from a team as code owners October 9, 2025 08:08
@mmorel-35 mmorel-35 marked this pull request as draft October 9, 2025 17:26
@mmorel-35 mmorel-35 force-pushed the settings-manager branch 17 times, most recently from 669944e to da5c5c6 Compare October 11, 2025 23:40
…ess; context now passed only to methods

Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant