Skip to content

Conversation

pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented Oct 9, 2025

Originally part of the AppSet UI PR: https://github.com/argoproj/argo-cd/pull/16689/files#diff-7035eb962aa6d0d147a318d9d131f4ce457e91e9f6aa4ac4a6ce0c5133616564 we are breaking it down to make it easier to review/test/

This PR introduces an abstraction layer for handling both Application and ApplicationSet types throughout the UI codebase. This is a foundational change that prepares the codebase to support ApplicationSet features in the future without duplicating code.

This PR should have zero functional impact on the UI. All existing Application functionality works exactly as before. No user-facing features are added or changed. Since no ApplicationSet routes exist:pathname is always /applications/*

This abstraction layer sets the foundation for future PRs that will:

  1. Add ApplicationSet UI Components - Create panels, details views, etc.
  2. Add ApplicationSet Routes - Enable navigation to /applicationsets

Each of these can now be implemented without duplicating all the Application code and reduce chance of regressions

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@pjiang-dev pjiang-dev requested a review from a team as a code owner October 9, 2025 23:46
Copy link

bunnyshell bot commented Oct 9, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant