fix: make webhook payload handlers recover from panics (cherry-pick #24862 for 2.14) #24926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a small guard that recovers and logs the panic and stack trace. Cover both the api-server and applicationset-controller webhooks. Signed-off-by: Jakub Ciolek <[email protected]>
This makes the signature more explicit. Signed-off-by: Jakub Ciolek <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #24926 +/- ##
=============================================
Coverage 55.41% 55.41%
=============================================
Files 339 340 +1
Lines 57499 57508 +9
=============================================
+ Hits 31864 31869 +5
- Misses 22927 22930 +3
- Partials 2708 2709 +1 ☔ View full report in Codecov by Sentry. |
rumstead
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: make webhook payload handlers recover from panics (#24862)