Skip to content

Conversation

dzahariev
Copy link

@dzahariev dzahariev commented Oct 10, 2025

Add health check for ServiceBinding and ServiceInstance resources managed by sap-btp-service-operator.

The resources can have status type "Succeeded" or "Failed" and for values are one of "True" or "False".
In following 2 cases resource is considered as "Degraded":

  • (Succeeded:False)
  • (Failed:True)

In case status is missing the resource it is considered as "Progressing"
And in all other cases it is considered as "Healthy"

Checklist:

  • (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@dzahariev dzahariev requested a review from a team as a code owner October 10, 2025 11:53
Copy link

bunnyshell bot commented Oct 10, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.78%. Comparing base (95b191d) to head (a3764c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24928      +/-   ##
==========================================
- Coverage   60.79%   60.78%   -0.01%     
==========================================
  Files         351      351              
  Lines       60439    60439              
==========================================
- Hits        36745    36739       -6     
- Misses      20772    20781       +9     
+ Partials     2922     2919       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzahariev dzahariev changed the title feat: Add health checks for ServiceBinding feat: Add health checks for ServiceBinding and ServiceInstance Oct 13, 2025
dzahariev and others added 2 commits October 13, 2025 15:03
Signed-off-by: Dobromir Zahariev <[email protected]>
…goproj#24944)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dzahariev dzahariev requested a review from a team as a code owner October 13, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant