Skip to content

Conversation

shota3506
Copy link

@shota3506 shota3506 commented Oct 12, 2025

This PR remove unnecessary lock value copy in test. It makes the native go vet ./... command pass.

The comment in the code is outdated - the deadlock is tested without accessing the lock from the test code.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@shota3506 shota3506 requested a review from a team as a code owner October 12, 2025 03:50
Copy link

bunnyshell bot commented Oct 12, 2025

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.78%. Comparing base (95b191d) to head (278a47a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24939      +/-   ##
==========================================
- Coverage   60.79%   60.78%   -0.02%     
==========================================
  Files         351      351              
  Lines       60439    60439              
==========================================
- Hits        36745    36737       -8     
- Misses      20772    20782      +10     
+ Partials     2922     2920       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant