chore: use expecter struct from mockery

[mmorel-35]

Description

Expecter struct from mockery allows to replace .On("Method") with .EXPECT().Method()

The migration has been done with the help of https://github.com/d0ubletr0uble/expecterlint but it is not a golangci-lint linter and as the argo is in go 1.25, this needs local recompilation to be use so it's not integrated in tooling. By the way testifylint has a task in process by the author of expecterlint to provide it as a new rule.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Title of the PR
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (95b191d) to head (fafd0e7).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #24940      +/-   ##
==========================================
- Coverage   60.79%   60.79%   -0.01%     
==========================================
  Files         351      351              
  Lines       60439    60439              
==========================================
- Hits        36745    36744       -1     
  Misses      20772    20772              
- Partials     2922     2923       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mmorel-35]

@crenshaw-dev ,

The TestAppRevisionsMultiSource is failing. Does the order matter here ? Any suggestion on the way to adress this ?