fix: reposerver should return syncRevision if no changes detected (#17280) #24947
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `argocd.argoproj.io/manifest-generate-paths` the user explicitly requests argocd NOT to sync if files irrelevant to the application change. The repo server logic did properly report no changes when this annotation is set, but it incorrectly reported the latest commit hash known to the repo server. This commit hash then pollutes the sync history of an application, because no actual sync of resources is happening and the history will show commits unrelated to the service. This change fixes this behaviour, and returns the provided syncRevision back to the caller if no new changes were detected since the syncRevision. Fixes argoproj#17280 Signed-off-by: Zoltán Reegn <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
reegnz
changed the title
|
It would also be great if this could be cherry-picked to v3.0 and v2.14 |
|
+1 The BunnyShell errors don't appear to be public. Requires a paid subscription and even with the trial, I can't see them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
argocd.argoproj.io/manifest-generate-pathsthe userexplicitly requests argocd NOT to sync if files irrelevant to the
application change.
The repo server logic did properly report no changes when this
annotation is set, but it incorrectly reported the latest commit hash
known to the repo server. This commit hash then pollutes the sync
history of an application, because no actual sync of resources is
happening and the history will show commits unrelated to the service.
This change fixes this behaviour, and returns the provided syncRevision
back to the caller if no new changes were detected since the
syncRevision.
Fixes #17280
Signed-off-by: Zoltán Reegn [email protected]
Checklist: