feat(cmp): add stdin support for Config Management Plugins#25917
Draft
glennpratt wants to merge 1 commit intoargoproj:masterfrom
Draft
feat(cmp): add stdin support for Config Management Plugins#25917glennpratt wants to merge 1 commit intoargoproj:masterfrom
glennpratt wants to merge 1 commit intoargoproj:masterfrom
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
This change introduces a new `stdin` field to the Application spec under `source.plugin.stdin`. The `stdin` value is interpolated with standard build environment variables and then passed via standard input to the CMP's `generate`, `discover`, and `parameters` commands. This allows passing large payloads to plugins without hitting exceeding limits on environment variables passing through execve: - Linux MAX_ARG_STRLEN is 128 KB - Linux MAX_ARG is generally 2 MB Both of these appear as `fork/exec PATH: argument list too long` errors. Fixes argoproj#17914 Signed-off-by: Glenn Pratt <gpratt@akamai.com>
f231a9d to
2f5b4cd
Compare
|
We have run into this issue as well. If we could just write directly to a temp file and then refer to the temp file that would be great too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new
stdinfield to the Application spec undersource.plugin.stdin. Thestdinvalue is interpolated with standard build environment variables and then passed via standard input to the CMP'sgenerate,discover, andparameterscommands.This allows passing large payloads to plugins without hitting exceeding limits on things passed as argument to execve, including environment variables:
Both of these appear as
fork/exec $path: argument list too longerrors.Fixes #17914
Checklist: