Skip to content

feat: add depth option to ui#26618

Merged
nitishfy merged 3 commits intoargoproj:masterfrom
blakepettersson:feature/add-depth-to-ui
Apr 8, 2026
Merged

feat: add depth option to ui#26618
nitishfy merged 3 commits intoargoproj:masterfrom
blakepettersson:feature/add-depth-to-ui

Conversation

@blakepettersson
Copy link
Copy Markdown
Member

@blakepettersson blakepettersson commented Feb 25, 2026

As a followup to #24931, it's also good to be able to set this option in the UI.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@blakepettersson
feat: add depth option to ui
44b9a02 
As a followup to argoproj#24931, it's also good to be able to set this option in
the UI.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson requested a review from a team as a code owner February 25, 2026 22:45
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Feb 25, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

nitishfy
nitishfy reviewed Feb 26, 2026
View reviewed changes
Comment thread ui/src/app/settings/components/repo-details/repo-details.tsx Outdated
nitishfy
nitishfy reviewed Feb 26, 2026
View reviewed changes
Comment thread ui/src/app/settings/components/repos-list/repos-list.tsx Outdated
nitishfy
nitishfy reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a UI expert but I've left a couple of comments. Let me know what do you think.

@blakepettersson
fix: add depth validation
600b38c 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
nitishfy
nitishfy approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitishfy nitishfy enabled auto-merge (squash) March 2, 2026 16:48
todaywasawesome
todaywasawesome approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might benefit from a tooltip but I wouldn't hold this up for that. Looks good

@blakepettersson blakepettersson added cherry-pick/3.3 Candidate for cherry picking into the 3.3 release cherry-pick/3.4 and removed cherry-pick/3.3 Candidate for cherry picking into the 3.3 release labels Apr 8, 2026
@nitishfy nitishfy merged commit a2b91ce into argoproj:master Apr 8, 2026
39 of 43 checks passed
argo-cd-cherry-pick-bot Bot pushed a commit that referenced this pull request Apr 8, 2026
@blakepettersson @github-actions
feat: add depth option to ui (#26618)
e6b926c 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@argo-cd-cherry-pick-bot argo-cd-cherry-pick-bot Bot mentioned this pull request Apr 8, 2026
Closed
@argo-cd-cherry-pick-bot
Copy link
Copy Markdown

argo-cd-cherry-pick-bot Bot commented Apr 8, 2026

🍒 Cherry-pick PR created for 3.4: #27223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blakepettersson @todaywasawesome @gdsoumya @nitishfy