fix: (call .repo.GetAppDetails).Helm is Null for multi-sources applications#26773
Open
aryasoni98 wants to merge 13 commits intoargoproj:masterfrom
Open
fix: (call .repo.GetAppDetails).Helm is Null for multi-sources applications#26773aryasoni98 wants to merge 13 commits intoargoproj:masterfrom
aryasoni98 wants to merge 13 commits intoargoproj:masterfrom
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Contributor
ppapapetrou76
left a comment
There was a problem hiding this comment.
Consider adding UTs especially for edge cases
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
….11.3 (argoproj#26771) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
Signed-off-by: pjmanda <jhansi.manda@amadeus.com> Signed-off-by: jhansireddy01 <m.jhansireddy01@gmail.com> Co-authored-by: pjmanda <jhansi.manda@amadeus.com> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: jhansireddy01 <m.jhansireddy01@gmail.com> Signed-off-by: Arya Soni <aryasoni98@gmail.com>
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
nitishfy
reviewed
Mar 10, 2026
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
…nto issue-26760
nitishfy
reviewed
Mar 10, 2026
nitishfy
reviewed
Mar 10, 2026
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
nitishfy
reviewed
Mar 10, 2026
nitishfy
reviewed
Mar 10, 2026
…ations Signed-off-by: Arya Soni <aryasoni98@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26773 +/- ##
==========================================
+ Coverage 62.97% 62.98% +0.01%
==========================================
Files 414 414
Lines 56154 56180 +26
==========================================
+ Hits 35362 35386 +24
Misses 17420 17420
- Partials 3372 3374 +2 ☔ View full report in Codecov by Sentry. |
Member
|
Please fix the lint checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26760
For multi-source Argo CD applications,
(call .repo.GetAppDetails)in notification templates always returnednilforHelm, so Helm values (e.g.image.tag) could not be read via$appDetails.Helm.GetParameterValueByName. The function always used source index 0, which for multi-source apps is often the values repo, not the Helm chart.This change adds an optional source index argument so callers can specify which source to inspect (e.g.
(call .repo.GetAppDetails 1)for the second source). It also passesRefSourcesfor multi-source apps so$valuesreferences in Helm value files resolve correctly.Checklist: