Skip to content

fix(ui): use revisions dropdown panel for the applications sync (#22658) (draft) #26784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwardBalaj wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

fix(ui): use revisions dropdown panel for the applications sync (#22658) (draft) #26784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui/src/app/applications/components/application-sync-panel/application-sync-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
PRUNE_SOME_WARNING
} from '../application-sync-options/application-sync-options';
import {ComparisonStatusIcon, getAppDefaultSource, nodeKey} from '../utils';
import {RevisionFormField} from '../revision-form-field/revision-form-field';

import './application-sync-panel.scss';

Expand All @@ -30,6 +31,7 @@ export const ApplicationSyncPanel = ({application, selectedResource, hide}: {app
const syncStrategy = {} as models.SyncStrategy;
const [isPending, setPending] = React.useState(false);
const source = getAppDefaultSource(application);
const repoType = source?.repoURL?.startsWith('oci://') ? 'oci' : source && Object.prototype.hasOwnProperty.call(source, 'chart') ? 'helm' : 'git';

return (
<Consumer>
Expand Down Expand Up @@ -252,7 +254,7 @@ export const ApplicationSyncPanel = ({application, selectedResource, hide}: {app
Synchronizing application manifests from <a href={source.repoURL}>{source.repoURL}</a>
</h6>
<div className='argo-form-row'>
<FormField formApi={formApi} label='Revision' field='revision' component={Text} />
<RevisionFormField formApi={formApi} repoURL={source.repoURL} repoType={repoType} fieldValue='revision' />
</div>

<div className='argo-form-row'>
Expand Down
Loading