fix: trigger app sync on app-set spec change#26811
Open
ppapapetrou76 wants to merge 3 commits intoargoproj:masterfrom
Open
fix: trigger app sync on app-set spec change#26811ppapapetrou76 wants to merge 3 commits intoargoproj:masterfrom
ppapapetrou76 wants to merge 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26811 +/- ##
=======================================
Coverage 62.98% 62.99%
=======================================
Files 414 414
Lines 56153 56166 +13
=======================================
+ Hits 35370 35382 +12
Misses 17416 17416
- Partials 3367 3368 +1 ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Mar 16, 2026
Member
ishitasequeira
left a comment
ishitasequeira
left a comment
There was a problem hiding this comment.
Overall changes look good. Added a nit!!
Comment on lines
+1205
to
+1211
| case revisionsChanged && specChanged: | ||
| newAppStatus.Message = "Application has pending changes (revision and spec differ), setting status to Waiting" | ||
| case revisionsChanged: | ||
| newAppStatus.Message = "Application has pending changes, setting status to Waiting" | ||
| default: | ||
| newAppStatus.Message = "Application has pending changes (spec differs), setting status to Waiting" | ||
| } |
Member
There was a problem hiding this comment.
nit: we are adding what differs in each message except for revisionsChanged. Shall we align on the message?
sivchari
reviewed
Mar 16, 2026
Comment on lines
+1204
to
+1211
| switch { | ||
| case revisionsChanged && specChanged: | ||
| newAppStatus.Message = "Application has pending changes (revision and spec differ), setting status to Waiting" | ||
| case revisionsChanged: | ||
| newAppStatus.Message = "Application has pending changes, setting status to Waiting" | ||
| default: | ||
| newAppStatus.Message = "Application has pending changes (spec differs), setting status to Waiting" | ||
| } |
Member
There was a problem hiding this comment.
How about making messages const ? I think it's better to do it since we can use same const in logic and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26585
Fixes the code top trigger applications sync when there's a change in the application set spec ( that apparantely generated the apps )
Checklist: