docs: clarify Helm hook delete-policy semantics#26828
Open
Vedant-Mhatre wants to merge 2 commits intoargoproj:masterfrom
Open
docs: clarify Helm hook delete-policy semantics#26828Vedant-Mhatre wants to merge 2 commits intoargoproj:masterfrom
Vedant-Mhatre wants to merge 2 commits intoargoproj:masterfrom
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Vedant-Mhatre <vedantmh@gmail.com>
Vedant-Mhatre
force-pushed
the
docs-hook-delete-policy-semantics
branch
from
f2aea30 to
c5f4af4
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26702
Summary
Clarify that Helm hook annotations are mapped onto Argo CD hooks at the annotation level, but hook delete-policy evaluation still follows Argo CD sync phases and sync result semantics rather than Helm's per-hook-event lifecycle.
What Changed
helm.sh/hook-delete-policyHookSucceededreflects overall sync semanticsServiceAccountcan behave differently from terminal hook resources such asJoborWorkflowVerification