feat(health): additional promoter.argoproj.io health checks#27170
Merged
crenshaw-dev merged 2 commits intoargoproj:masterfrom Apr 13, 2026
Merged
feat(health): additional promoter.argoproj.io health checks#27170crenshaw-dev merged 2 commits intoargoproj:masterfrom
crenshaw-dev merged 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27170 +/- ##
==========================================
+ Coverage 63.33% 63.37% +0.03%
==========================================
Files 415 415
Lines 56545 56548 +3
==========================================
+ Hits 35815 35835 +20
+ Misses 17350 17336 -14
+ Partials 3380 3377 -3 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
changed the title
leoluz
reviewed
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
General question: What do you think if we add a comment to those health checks with at link to the Go type that they are based on? It could serve as a reference to CRD version that used to base the check. WDYT?
Member
Author
There was a problem hiding this comment.
Good call. I'm gonna open a follow up PR to add some nicer messages for finalizers, I'll add some comments with links in that PR.
leoluz
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding health check for additional promoter.argoproj.io kinds.