fix(applicationset): prevent prune state leakage in RollingSync (fixes #27261)#27284
Closed
sahanajc4 wants to merge 2 commits intoargoproj:masterfrom
Closed
fix(applicationset): prevent prune state leakage in RollingSync (fixes #27261)#27284sahanajc4 wants to merge 2 commits intoargoproj:masterfrom
sahanajc4 wants to merge 2 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
49427b8 to
1700dc9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27284 +/- ##
==========================================
+ Coverage 63.34% 63.37% +0.02%
==========================================
Files 415 415
Lines 56694 56701 +7
==========================================
+ Hits 35914 35934 +20
+ Misses 17396 17380 -16
- Partials 3384 3387 +3 ☔ View full report in Codecov by Sentry. |
…ge SyncOperation.Prune from bool to *bool to distinguish unset vs false- explicitly set prune in every RollingSync sync operation- safely convert *bool to bool when passing to sync engine- update tests to use pointer semantics- add test case for prune toggle (true -> false)Fixes issue where previous prune=true persisted across operations and caused unintended pruning. Signed-off-by: Sahana <sahanajavgal7@gmail.com>
1700dc9 to
db4ec78
Compare
0e9f3c4 to
b91c8e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safely converting
*booltoboolwhen passing to the sync engine to maintain compatibility:Updating unit tests to use pointer semantics
Adding a test case covering prune toggle (
true → false)Result
prune=falseis now correctly respected in subsequent RollingSync operationsScope
Testing
Checklist
Fixes #27261
Signed-off-by: sahanjc4 < sahanajavgal7@gmail.com >