Skip to content

chore(CODEOWNERS): expand @argoproj/argocd-approvers-ci role ownership#27721

Open
dudinea wants to merge 3 commits intoargoproj:masterfrom
dudinea:argocd_approvers_ci_role
Open

chore(CODEOWNERS): expand @argoproj/argocd-approvers-ci role ownership#27721
dudinea wants to merge 3 commits intoargoproj:masterfrom
dudinea:argocd_approvers_ci_role

Conversation

@dudinea
Copy link
Copy Markdown
Member

@dudinea dudinea commented May 6, 2026

Implements expansion of @argoproj/argocd-approvers-ci ownership
to the files/directories related to CI, build and code scanning configurations.

The hack/ directory is somewhat messy, the most compact way
seems to be use exclusions for unrelated stuff.

Some of this stuff is related to documentation generation,
like "/hack/gen-docs/" and some other scripts.
should be given to the @argoproj/argocd-approvers-docs?

Closes: #27697

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

dudinea added 3 commits May 6, 2026 19:17
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
@dudinea dudinea requested a review from a team as a code owner May 6, 2026 17:13
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 6, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (14b9d68) to head (727c6b0).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27721      +/-   ##
==========================================
+ Coverage   63.84%   63.88%   +0.03%     
==========================================
  Files         418      417       -1     
  Lines       57269    57211      -58     
==========================================
- Hits        36566    36547      -19     
+ Misses      17290    17256      -34     
+ Partials     3413     3408       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@ppapapetrou76 ppapapetrou76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resurrect and expand the Approvers(ci) scoped role

5 participants