chore(CODEOWNERS): expand @argoproj/argocd-approvers-ci role ownership#27721
Open
dudinea wants to merge 3 commits intoargoproj:masterfrom
Open
chore(CODEOWNERS): expand @argoproj/argocd-approvers-ci role ownership#27721dudinea wants to merge 3 commits intoargoproj:masterfrom
dudinea wants to merge 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27721 +/- ##
==========================================
+ Coverage 63.84% 63.88% +0.03%
==========================================
Files 418 417 -1
Lines 57269 57211 -58
==========================================
- Hits 36566 36547 -19
+ Misses 17290 17256 -34
+ Partials 3413 3408 -5 ☔ View full report in Codecov by Sentry. |
ppapapetrou76
approved these changes
May 7, 2026
Contributor
ppapapetrou76
left a comment
There was a problem hiding this comment.
LGTM - great addition
blakepettersson
approved these changes
May 7, 2026
nitishfy
approved these changes
May 7, 2026
6 tasks
reggie-k
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements expansion of @argoproj/argocd-approvers-ci ownership
to the files/directories related to CI, build and code scanning configurations.
The hack/ directory is somewhat messy, the most compact way
seems to be use exclusions for unrelated stuff.
Some of this stuff is related to documentation generation,
like "/hack/gen-docs/" and some other scripts.
should be given to the @argoproj/argocd-approvers-docs?
Closes: #27697
Checklist: