fix(ui): add url origin to return_url#27733
Open
Sumis34 wants to merge 1 commit intoargoproj:masterfrom
Open
Conversation
Signed-off-by: krebsnoe <noe.krebs@post.ch>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
ranakan19
approved these changes
May 8, 2026
Member
ranakan19
left a comment
There was a problem hiding this comment.
Thanks for catching that, lgtm!
@keithchong @aali309 interested in your thoughts here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #25463 introduced a bug where the return_url was not set correctly, and the argo-server marked it as invalid because it did not contain the origin, only
/some_path?and=paramsthis change adds the full URL as a return_url. This was already done like this in other places of the codebase.Checklist:
/cc @the-technat