Skip to content

fix(ui): add url origin to return_url#27733

Open
Sumis34 wants to merge 1 commit intoargoproj:masterfrom
swisspost:fix/return_url
Open

fix(ui): add url origin to return_url#27733
Sumis34 wants to merge 1 commit intoargoproj:masterfrom
swisspost:fix/return_url

Conversation

@Sumis34
Copy link
Copy Markdown

@Sumis34 Sumis34 commented May 7, 2026

The PR #25463 introduced a bug where the return_url was not set correctly, and the argo-server marked it as invalid because it did not contain the origin, only /some_path?and=params this change adds the full URL as a return_url. This was already done like this in other places of the codebase.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

/cc @the-technat

Signed-off-by: krebsnoe <noe.krebs@post.ch>
@Sumis34 Sumis34 requested a review from a team as a code owner May 7, 2026 09:58
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 7, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link
Copy Markdown
Member

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, lgtm!
@keithchong @aali309 interested in your thoughts here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants