Skip to content

feat: surface root cause in sync failure message and cache discovery errors#27750

Open
ppapapetrou76 wants to merge 2 commits intoargoproj:masterfrom
ppapapetrou76:issue-27659-app-controller-panic
Open

feat: surface root cause in sync failure message and cache discovery errors#27750
ppapapetrou76 wants to merge 2 commits intoargoproj:masterfrom
ppapapetrou76:issue-27659-app-controller-panic

Conversation

@ppapapetrou76
Copy link
Copy Markdown
Contributor

@ppapapetrou76 ppapapetrou76 commented May 8, 2026

Closes #27659

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 8, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-m3dxtv.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-m3dxtv.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@ppapapetrou76 ppapapetrou76 changed the title fixes a nil pointer exception in getSyncTasks fix: fixes a nil pointer exception in getSyncTasks May 8, 2026
@ppapapetrou76 ppapapetrou76 changed the title fix: fixes a nil pointer exception in getSyncTasks feat: surface root cause in sync failure message and cache discovery errors May 8, 2026
@ppapapetrou76 ppapapetrou76 force-pushed the issue-27659-app-controller-panic branch from d96f2aa to 5e8c2be Compare May 8, 2026 08:47
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.89%. Comparing base (97e31db) to head (f3723a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27750      +/-   ##
==========================================
+ Coverage   63.87%   63.89%   +0.01%     
==========================================
  Files         421      421              
  Lines       57657    57672      +15     
==========================================
+ Hits        36828    36847      +19     
+ Misses      17370    17364       -6     
- Partials     3459     3461       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
@ppapapetrou76 ppapapetrou76 force-pushed the issue-27659-app-controller-panic branch from 5e8c2be to bd3c55b Compare May 8, 2026 10:15
@ppapapetrou76 ppapapetrou76 marked this pull request as ready for review May 8, 2026 10:17
@ppapapetrou76 ppapapetrou76 requested a review from a team as a code owner May 8, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

application-controller: nil pointer panic in getSyncTasks when target cluster API discovery times out

1 participant