test: add t.Parallel() to util collections, io, rand, security tests (#27423)#27771
Open
GuruduGanesh wants to merge 1 commit intoargoproj:masterfrom
Open
test: add t.Parallel() to util collections, io, rand, security tests (#27423)#27771GuruduGanesh wants to merge 1 commit intoargoproj:masterfrom
GuruduGanesh wants to merge 1 commit intoargoproj:masterfrom
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27771 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 421 421
Lines 57774 57774
=======================================
+ Hits 36954 36956 +2
+ Misses 17339 17337 -2
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
…rgoproj#27423) Signed-off-by: GuruduGanesh <ganesh.gurudu@gmail.com>
4a8a406 to
ef5b7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#27423)
Description
Refs #27423.
Adds
t.Parallel()to a small batch of utility unit tests where the tests are isolated and safe to run in parallel.This updates tests under:
util/collectionsutil/ioutil/io/pathutil/randutil/securityTestGetPathIfExistsis intentionally left sequential because its subtests share the sameRandomizedTempPathsinstance and depend on execution order. The"does not exist"case must run before the"does exist"case populates the path.TestGetPaths_no_raceis also intentionally left sequential because it is a race smoke test that starts goroutines usingtesting.T.Testing
Checklist: