chore(UI deps): bump js-yaml to 4.3.0 to fix CVE-2026-59869#28839
chore(UI deps): bump js-yaml to 4.3.0 to fix CVE-2026-59869#28839aali309 wants to merge 7 commits into
Conversation
Signed-off-by: Atif Ali <atali@redhat.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
PR Summary by QodoBump UI js-yaml to 4.3.0 and pin overrides to remediate CVE-2026-59869
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
There was a problem hiding this comment.
Pull request overview
This PR updates the UI’s js-yaml dependency to address CVE-2026-59869, and adds pnpm overrides to ensure both js-yaml@^4 and transitive js-yaml@^3 consumers resolve to patched versions.
Changes:
- Bump UI direct dependency
js-yamlto^4.3.0. - Add pnpm overrides for
js-yaml@^3→3.15.0andjs-yaml@^4→4.3.0. - Update
pnpm-lock.yamlresolutions accordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/package.json | Bumps js-yaml to ^4.3.0 and adds pnpm overrides for js-yaml v3/v4. |
| ui/pnpm-lock.yaml | Updates lockfile to reflect the new js-yaml resolutions and overrides. |
Files not reviewed (1)
- ui/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| js-yaml: | ||
| specifier: ^4.1.1 | ||
| version: 4.2.0 | ||
| specifier: 4.3.0 | ||
| version: 4.3.0 |
Code Review by Qodo
Context used✅ Compliance rules (platform):
13 rules🔴 Action Required 1.
|
| @@ -59,8 +61,8 @@ importers: | |||
| specifier: ^4.7.2 | |||
| version: 4.10.1 | |||
| js-yaml: | |||
There was a problem hiding this comment.
1. Lockfile specifier mismatch 🐞 Bug ☼ Reliability
ui/pnpm-lock.yaml records js-yaml with an exact manifest specifier (4.3.0) while ui/package.json declares ^4.3.0, so pnpm installs with frozen lockfile validation can fail as “lockfile is out of date”. This is a deterministic CI/reproducibility break for environments using --frozen-lockfile (or equivalent).
Agent Prompt
### Issue description
`ui/package.json` declares `js-yaml` as `^4.3.0`, but `ui/pnpm-lock.yaml` importer entry shows `specifier: 4.3.0`. pnpm expects the lockfile importer `specifier` to match the package.json specifier; otherwise `pnpm install --frozen-lockfile` will error.
### Issue Context
This PR changed both the manifest and lockfile, but left `js-yaml`'s importer specifier inconsistent with the manifest.
### Fix Focus Areas
- ui/package.json[24-70]
- ui/pnpm-lock.yaml[58-66]
### Suggested fix
Either:
1) Re-run `pnpm install` (with the repo’s pnpm version) so `ui/pnpm-lock.yaml` is regenerated and its importer `specifier` becomes `^4.3.0`, **or**
2) If you intended to pin exactly, change `ui/package.json` dependency to `"js-yaml": "4.3.0"` to match the lockfile.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Bundle ReportBundle size has no change ✅ |
Signed-off-by: Atif Ali <atali@redhat.com>
| js-yaml: | ||
| specifier: ^4.1.1 | ||
| version: 4.2.0 | ||
| specifier: ^4.3.0 | ||
| version: 4.3.0 |
Signed-off-by: Atif Ali <atali@redhat.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- ui/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
ui/pnpm-lock.yaml:63
- The lockfile still includes js-yaml@4.1.1 (and 3.x) as transitive dependencies (e.g.,
@redocly/openapi-coredepends on js-yaml 4.1.1), so bumping the top-level js-yaml specifier alone may not fully eliminate older js-yaml versions from the install. If the CVE affects those older versions, consider adding a pnpm override for js-yaml and/or updating the transitive dependency that pins 4.1.1, then re-generating the lockfile.
| "git-url-parse": "^13.1.0", | ||
| "history": "^4.7.2", | ||
| "js-yaml": "^4.1.1", | ||
| "js-yaml": "^4.3.0", |
Signed-off-by: Atif Ali <atali@redhat.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- ui/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
ui/pnpm-lock.yaml:65
pnpm-lock.yamlis out of sync withui/package.json: the importer entry forjs-yamlrecordsspecifier: 4.3.0, but the manifest declares"js-yaml": "^4.3.0". This mismatch can causepnpm install --frozen-lockfileto fail or force a lockfile rewrite in CI.
| version: 4.10.1 | ||
| js-yaml: | ||
| specifier: ^4.1.1 | ||
| specifier: 4.3.0 |
There was a problem hiding this comment.
@aali309 was this set after the lock file was regenerated? The suggestion was to have it set to ^4.3.0
There was a problem hiding this comment.
The broad override js-yaml@^4 → 4.3.0 made pnpm rewrite the lockfile to exact 4.3.0. I had pinned package.json to match that, which broke consistency with the other deps.
Signed-off-by: Atif Ali <atali@redhat.com>
Fixes: CVE-2026-59869
Checklist: