fix: allow gitlab eventsource to work without projects or groups #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Priscillesg
changed the title
Priscillesg
changed the title
ryancurrah
reviewed
Mar 6, 2025
| @@ -858,7 +858,7 @@ type GitlabEventSource struct { | |||
| // Metadata holds the user defined metadata which will passed along the event payload. | |||
| // +optional | |||
| Metadata map[string]string `json:"metadata,omitempty" protobuf:"bytes,9,rep,name=metadata"` | |||
| // List of project IDs or project namespace paths like "whynowy/test". Projects and groups cannot be empty at the same time. | |||
| // List of project IDs or project namespace paths like "whynowy/test". | |||
There was a problem hiding this comment.
Can you add that not defining a group or project means the event source will not manage webhooks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the Gitab EventSource validation logic to allow configurations without
projectsorgroups. This change ensures that users can manage webhooks externally while still using Argo Events.Changes
projectsandgroupsinvalidate.go.validate_test.goto reflect the new behavior.Testing
go test -v ./pkg/eventsources/sources/gitlab/ -run TestValidateEventSourcesuccessfully.@ryancurrah