fix(argocd-image-updater): Add webhook port to NetworkPolicy #3681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3678
I hesitated to create a
networkPolicy.createoption in the values.yaml (juste like argo-cd helm), but this means either changing the default behavior, or having different default values between helms (since the default if false for argo-cd networkPolicy, but right now argocd-image-updater deploys a NetworkPolicy if the metric server is enabled)I also don't like very much adding the webhook port to a NetworkPolicy named
argocd-image-updater-allow-metricsbut I wanted a minimal change, I'm open to better suggestion!First time contributing to anything open source, I spend way too much time editing those 2 lines to make sure everything's in order
Checklist: