feat(argo-cd): Add optional grafana dashboard (#2725)#3923
Conversation
|
Can you please point me in the direction of where I can find this in the upstream release manifests? Unsurprisingly I am extremely not keen on a 5000 line commit. |
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
|
https://github.com/grafana-community/helm-charts/tree/main/charts/grafana#sidecar-for-dashboards explains how grafana's dashboard sidecar can automatically import dashboards. |
|
I know how grafana's sidecar can do that but this isn't something contained within argocd's official release. |
|
I pulled the dashboard in from : https://github.com/argoproj/argo-cd/blob/master/examples/dashboard.json |
|
I know. That's also not the official release manifest. |
|
Is this chart's policy to only include items from the tagged release manifest - excluding any items from the source tree which are not part of the explicitly provided items? |
|
As stated in the README as official Helm Chart we only support released upstream versions: |
|
I tend to view the content of the repo as part of the upstream release at the tagged commit - https://github.com/argoproj/argo-cd/archive/refs/tags/v3.4.3.tar.gz contains the dashboard.json file. I guess this is a difference of philosophy. The dashboard is referenced directly at:
Argo-cd itself has no runtime changes with this applied. If you don't feel that this config map appropriate, I can close out this PR. I was just trying to make a smooth path for rendering the existing prometheus monitors within the chart. |
Checklist:
This PR should permit folks to optionally install the example grafana dashboard in a way that the grafana sidecar can detect.