feat: print error message in message field inside status in rollouts … #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Published E2E Test Results 4 files 4 suites 5h 12m 13s ⏱️ For more details on these failures, see this check. Results for commit 0af3b0a. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 307 tests 2 307 ✅ 2m 59s ⏱️ Results for commit 0af3b0a. ♻️ This comment has been updated with latest results. |
|
…object Signed-off-by: Abhishek Bansal <[email protected]>
Signed-off-by: Abhishek Bansal <[email protected]>
Signed-off-by: Abhishek Bansal <[email protected]>
Abhish2702
force-pushed
the
print-error-message
branch
from
21827ac to
a16701f
Compare
|
@zachaller could you please provide some help to resolve the failures on end to end testing ? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Improved Error Reporting in Rollouts Controller
This PR introduces an enhancement to the rollouts controller, allowing it to record reconciliation error messages directly in the status field of Rollout objects.
Benefits:
Enhanced User Experience: Users can now view error messages associated with a Rollout object directly in its status, eliminating the need to search through the controller logs for debugging purposes.
Faster Issue Resolution: By surfacing errors in the status field, users can identify and address issues more efficiently, streamlining the troubleshooting process.
This enhancement is aimed at improving the overall usability and developer experience while working with Rollout objects.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".