Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make sure rollouts abort always has some more detailed message (#3957) #4175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Mar 5, 2025

Closes #3957

Sometimes the rollout aborted message is just that, without any reason. Adding more detailed abort messages here.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

…argoproj#3957)

Closes argoproj#3957

Sometimes the rollout aborted message is just that, without any reason. Adding more detailed abort messages here.

Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Published E2E Test Results

  4 files    4 suites   3h 15m 49s ⏱️
114 tests 103 ✅  7 💤 4 ❌
460 runs  428 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit e4a8483.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Published Unit Test Results

2 306 tests   2 306 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit e4a8483.

@zachaller zachaller added this to the v1.9 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show more information in the UI about why Rollout gets aborted
2 participants