fix(controller): fix waiting for stable rs to be fully scaled before canary scale down with dynamicStableScale

[nebojsa-prodana]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 11m 30s ⏱️
114 tests 105 ✅  7 💤 2 ❌
458 runs  428 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 860dc9b.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 313 tests   2 313 ✅  3m 2s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 860dc9b.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate failed

Failed conditions
47.8% Duplication on New Code (required ≤ 40%)

See analysis details on SonarQube Cloud

[zachaller]

The tests seem to pass with and without the changes in the PR can you make sure the tests fail without these changes.