Skip to content

Conversation

@LiorFriedmanYahoo
Copy link

Hi community, we're Noy and Lior from the Kubernetes team at Yahoo. We're using Argo Rollouts with Google Managed Prometheus and want to contribute our work to the project.

Fixes #3307.

We refrained from adding tests because the change is very minimal, and it's difficult to test without bringing up a GMP instance. We did test this authentication method on our infrastructure.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

LiorFriedmanYahoo and others added 3 commits May 11, 2025 12:43
Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Noy Segal <[email protected]>
Co-authored-by: Noy Segal <[email protected]>
Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Noy Segal <[email protected]>
Co-authored-by: Noy Segal <[email protected]>
Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Noy Segal <[email protected]>
Co-authored-by: Noy Segal <[email protected]>
@zachaller zachaller added this to the v1.9 milestone May 13, 2025
@zachaller zachaller enabled auto-merge (squash) May 13, 2025 15:21
Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Noy Segal <[email protected]>
Co-authored-by: Noy Segal <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Published E2E Test Results

  4 files    4 suites   4h 11m 16s ⏱️
117 tests 105 ✅  7 💤  5 ❌
500 runs  438 ✅ 28 💤 34 ❌

For more details on these failures, see this check.

Results for commit 9b24bbb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Published Unit Test Results

2 365 tests   2 365 ✅  3m 3s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 9b24bbb.

♻️ This comment has been updated with latest results.

auto-merge was automatically disabled May 13, 2025 15:59

Head branch was pushed to by a user without write access

@LiorFriedmanYahoo
Copy link
Author

@zachaller thank you for approving. I fixed the formatting error, can you please re-run the workflows?

Signed-off-by: LiorFriedmanYahoo <[email protected]>
@LiorFriedmanYahoo
Copy link
Author

@zachaller Can you please merge? For some reason auto merging got disabled.

@sonarqubecloud
Copy link

@noy93845
Copy link

@zachaller hey Zach, when will this PR be merged?

@zachaller zachaller enabled auto-merge (squash) November 2, 2025 22:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants