-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(metricprovider): Add Google Managed Prometheus auth #4275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lior Friedman <[email protected]> Signed-off-by: Noy Segal <[email protected]> Co-authored-by: Noy Segal <[email protected]>
Signed-off-by: Lior Friedman <[email protected]> Signed-off-by: Noy Segal <[email protected]> Co-authored-by: Noy Segal <[email protected]>
Signed-off-by: Lior Friedman <[email protected]> Signed-off-by: Noy Segal <[email protected]> Co-authored-by: Noy Segal <[email protected]>
Signed-off-by: Lior Friedman <[email protected]> Signed-off-by: Noy Segal <[email protected]> Co-authored-by: Noy Segal <[email protected]>
Published E2E Test Results 4 files 4 suites 4h 11m 16s ⏱️ For more details on these failures, see this check. Results for commit 9b24bbb. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 365 tests 2 365 ✅ 3m 3s ⏱️ Results for commit 9b24bbb. ♻️ This comment has been updated with latest results. |
Head branch was pushed to by a user without write access
|
@zachaller thank you for approving. I fixed the formatting error, can you please re-run the workflows? |
Signed-off-by: LiorFriedmanYahoo <[email protected]>
|
@zachaller Can you please merge? For some reason auto merging got disabled. |
|
|
@zachaller hey Zach, when will this PR be merged? |
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
|



Hi community, we're Noy and Lior from the Kubernetes team at Yahoo. We're using Argo Rollouts with Google Managed Prometheus and want to contribute our work to the project.
Fixes #3307.
We refrained from adding tests because the change is very minimal, and it's difficult to test without bringing up a GMP instance. We did test this authentication method on our infrastructure.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".