fix(controller): prevent crash-looping pods from resetting progress deadline. Fixes #3765

[ypopivniak-cg]

When pods crash-loop, ReadyReplicas/AvailableReplicas oscillate (e.g. 91→92→91→92) as pods briefly start before crashing again. Each upswing is treated as progress by RolloutProgressing(), resetting the Progressing condition's LastUpdateTime and preventing ProgressDeadlineExceeded from ever firing.

This PR splits RolloutProgressing() into two functions:

• RolloutScalingProgress() — structural changes (replica scaling, step advancement, selector switches). Always resets the deadline.
• RolloutReadinessProgress() — ReadyReplicas/AvailableReplicas increases. Does NOT reset the deadline when the Progressing condition already exists with ReplicaSetUpdatedReason.

Applies to both Canary and BlueGreen strategies.

Fixes: #3765

Current behavior:
Rollout gets stuck in Progressing phase indefinitely when canary pods crash-loop, because replica readiness oscillation keeps resetting the progress deadline clock.

Expected behavior:
After progressDeadlineSeconds elapses without structural progress, the Rollout transitions to Degraded phase with ProgressDeadlineExceeded reason.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• I have run all tests locally (including the flaky ones) and they pass on my workstation
• I have used LLM/AI/Agent tools for this PR but I am responsible for all code of this PR
• I understand what the code does and WHY/HOW it works in several scenarios
• I know if my code is just adding new functionality or changing old functionality for existing users
• My organization is added to USERS.md.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.01%. Comparing base (76a703a) to head (a262722).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4769      +/-   ##
==========================================
+ Coverage   84.99%   85.01%   +0.02%     
==========================================
  Files         164      164              
  Lines       18998    19005       +7     
==========================================
+ Hits        16147    16158      +11     
+ Misses       1998     1996       -2     
+ Partials      853      851       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 38m 54s ⏱️
120 tests 109 ✅  7 💤 4 ❌
484 runs  452 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit a262722.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 479 tests   2 479 ✅  3m 21s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit a262722.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud