fix: add missing glob prop to Autocomplete to match RenderAutocomplete#596
Open
jiwlee97 wants to merge 2 commits into
Open
fix: add missing glob prop to Autocomplete to match RenderAutocomplete#596jiwlee97 wants to merge 2 commits into
jiwlee97 wants to merge 2 commits into
Conversation
Signed-off-by: jiwlee <ddazi9576@gmail.com>
…lete Signed-off-by: jiwlee <ddazi9576@gmail.com>
jiwlee97
marked this pull request as ready for review
October 20, 2025 16:17
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
Just noticed that
globwasn’t passed toAutocomplete, so this PR adds it and also extracts a shared prop type for consistency.Apologies for the oversight — I’ll be more careful with similar updates going forward!
Summary
Adds
glob?: boolean | IOptionsto the Autocomplete component to align with RenderAutocomplete.Context
In a previously merged PR that introduced
globsupport forRenderAutocomplete, the same option was unintentionally omitted fromAutocomplete.This PR addresses that omission.
Changes
glob?: boolean | IOptionstoAutocompleteprops to matchRenderAutocompleteAutocompleteComponentPropsand use it in both components (no behavior change)