Skip to content

fix: process aggregate outputs for nodes with retries. Fixes #14228 #14299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: process aggregate outputs for nodes with retries. Fixes #14228 #14299

wants to merge 1 commit into from
+83 −2

Conversation

jswxstw
Copy link
Member

@jswxstw jswxstw commented Mar 14, 2025 •
edited
Loading

Fixes #14228

Motivation

Fail to process aggregate outputs for nodes with retries.

Modifications

  1. Support aggregating outputs for nodes of Retry type(excluding their children).
  2. Support extracting the index of child node if its name has extra brackets.

Verification

local test and e2e test

Documentation

@jswxstw jswxstw marked this pull request as draft March 17, 2025 02:11
@jswxstw jswxstw force-pushed the fix-14228 branch 2 times, most recently from 3c50fe2 to 18f55ac Compare March 17, 2025 03:21
@jswxstw jswxstw marked this pull request as ready for review March 17, 2025 03:51
@jswxstw
Copy link
Member Author

jswxstw commented Mar 18, 2025

/retest

tczhao
tczhao approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. However, there may be bugs resulted from this change, I'm relying on testing framework to test the changes. It's a starting point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DAG outputs from task parameter don't work with a retry strategy
2 participants
@jswxstw @tczhao