Skip to content

fix(test): for "CI / Windows Unit Tests", skip TestSessionReconnect#15895

Open
nakatani-yo wants to merge 1 commit intoargoproj:mainfrom
nakatani-yo:fix-session_test
Open

fix(test): for "CI / Windows Unit Tests", skip TestSessionReconnect#15895
nakatani-yo wants to merge 1 commit intoargoproj:mainfrom
nakatani-yo:fix-session_test

Conversation

@nakatani-yo
Copy link
Copy Markdown
Contributor

@nakatani-yo nakatani-yo commented Apr 9, 2026

Motivation

  • The test for github.com/argoproj/argo-workflows/v4/util/sqldb in "CI / Windows Unit Tests" failed.
--- FAIL: TestSessionReconnect (16.11s)
    session_test.go:89: 
        	Error Trace:	D:/a/argo-workflows/argo-workflows/util/sqldb/session_test.go:89
        	Error:      	Received unexpected error:
        	            	run postgres: generic container: create container: ensure default network: network create: Error response from daemon: could not find plugin bridge in v1 plugin registry: plugin not found
        	Test:       	TestSessionReconnect
FAIL
coverage: 0.0% of statements
  • This error "could not find plugin bridge in v1 plugin registry" indicates that the Docker daemon could not create a bridge network for Linux containers, meaning the Linux container execution infrastructure is not available in that environment. This can occur on Windows if Docker is running in Windows Containers mode, or if the bridge network driver is corrupted or disabled.

  • Confirmed runs-on: windows-2022 in .github/workflows/ci-build.yaml.

  • TestSessionReconnect uses the Linux-based PostgreSQL test container (postgres:17.4-alpine). On Windows CI, that assumption does not hold, which causes the test to fail for an environment-specific reason rather than due to product behavior.

For details on how to specify the test container, please refer to the following:
https://github.com/argoproj/argo-workflows/blob/main/util/sqldb/session_test.go#L30

Please refer to the following link for details regarding the supported platforms for postgres:17.4-alpine:
https://hub.docker.com/layers/library/postgres/17.4-alpine/

Modifications

  • Skipped TestSessionReconnect when runtime.GOOS == "windows".
  • Added the runtime import required for the platform check.

Verification

Documentation

  • No documentation updates are required for this test-only change.

…nnect.

Signed-off-by: nakatani-yo <yoshihito.nakatani@craftsman-software.com>
@nakatani-yo nakatani-yo changed the title fix(test): for CI on the Windows platform, skip test: TestSessionReconnect fix(test): for "CI / Windows Unit Tests", skip TestSessionReconnect Apr 9, 2026
@nakatani-yo nakatani-yo closed this Apr 9, 2026
@nakatani-yo nakatani-yo reopened this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant